Cleanup exclusions #1223
Merged
Cleanup exclusions #1223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the following no longer needed exclusions from the pulsar-client-all dependency in the spring-pulsar module: - `org.apache.logging.log4j:*` - `com.google.protobuf:protobuf-java` Signed-off-by: onobc <[email protected]>
This commit excludes the 'commons-logging' transitive dependency from the pulsar-client-all dependency in the spring-pulsar module. Signed-off-by: onobc <[email protected]>
onobc
added
the
type: improvement
onobc
commented
Aug 14, 2025
| dependencies { | ||
| api 'io.micrometer:micrometer-observation' | ||
| api (libs.pulsar.client.all) { | ||
| exclude group: 'commons-logging', module: 'commons-logging' |
There was a problem hiding this comment.
Hi @snicoll,
You should be able to remove the numerous exclusions in spring-projects/spring-boot@ad8ca01 once this is merged.
Note
The spring-pulsar-reactive module also leverages these exclusions in spring-pulsar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.